Add MatMul symbol #434
Merged
Add MatMul symbol #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcondello
reviewed
Nov 21, 2025
dwave/optimization/include/dwave-optimization/nodes/linear_algebra.hpp
Outdated
Show resolved
Hide resolved
dwave/optimization/include/dwave-optimization/nodes/linear_algebra.hpp
Outdated
Show resolved
Hide resolved
wbernoudy
commented
Nov 21, 2025
and address review comments
and add asserts in SizeInfo::operator/
arcondello
approved these changes
Nov 25, 2025
Member
arcondello
left a comment
arcondello
left a comment
There was a problem hiding this comment.
Logic all seems good to me with the possible exception of the size_from_shape() method and dynamic shapes.
Otherwise just a few nits.
dwave/optimization/include/dwave-optimization/nodes/linear_algebra.hpp
Outdated
Show resolved
Hide resolved
and use it in MatrixMultiplyNode, along with other small code improvements. Also fixed a bug in the ValuesInfo for MatrixMultiplyNode as it was not always calculating the contracted axis size correctly.
arcondello
approved these changes
Nov 26, 2025
Member
|
Just occurred to me, we should probably overload |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(still working on the symbol part)MatrixMultiplysymbol now handles vector-vector, matrix-vector, and ndarray-vector multiplication. Thematmulmethod will also add inBroadcastsymbols to one or both operands to handle the rest of the implicit broadcasting behavior thatnp.matmulsupports.